aleitner commented on code in PR #796:
URL: https://github.com/apache/guacamole-client/pull/796#discussion_r1117740135
##########
guacamole/src/main/frontend/src/app/clipboard/directives/guacClipboard.js:
##########
@@ -92,17 +141,23 @@ angular.module('clipboard').directive('guacClipboard',
['$injector',
// that indicate the clipboard field may have been changed
element.addEventListener('input', updateClipboardData);
element.addEventListener('change', updateClipboardData);
+ element.addEventListener('focus', displayAndUpdateClipboardEditor);
+ element.addEventListener('blur', hideAndUpdateClipboardEditor);
Review Comment:
This is how I originally had planned to do it, but I felt like it's more
secure to just hide whenever it isn't focused in case of password copying
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]