jmuehlner commented on code in PR #796:
URL: https://github.com/apache/guacamole-client/pull/796#discussion_r1117755536
##########
guacamole/src/main/frontend/src/app/clipboard/directives/guacClipboard.js:
##########
@@ -92,17 +141,23 @@ angular.module('clipboard').directive('guacClipboard',
['$injector',
// that indicate the clipboard field may have been changed
element.addEventListener('input', updateClipboardData);
element.addEventListener('change', updateClipboardData);
+ element.addEventListener('focus', displayAndUpdateClipboardEditor);
+ element.addEventListener('blur', hideAndUpdateClipboardEditor);
Review Comment:
I don't think there's any one single correct answer for this one - I could
see some users (like me) getting frustrated when the clipboard contents keep
getting hidden while working in a connection, making it more difficult to keep
track of the clipboard content.
On the other hand, I could see why some users might want to automatically
rehide every time, in case they copy a password locally and have it get
populated into their clipboard in the background without realizing it.
I almost wonder if this should be a configuration setting...
@mike-jumper thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
