jmuehlner commented on code in PR #796:
URL: https://github.com/apache/guacamole-client/pull/796#discussion_r1119106733
##########
guacamole/src/main/frontend/src/app/clipboard/directives/guacClipboard.js:
##########
@@ -40,33 +40,38 @@ angular.module('clipboard').directive('guacClipboard',
['$injector',
var config = {
restrict : 'E',
replace : true,
+ scope: {
+ /**
+ * When isActive is set to true then the Clipboard data will be
+ * displayed in the Clipboard Editor. When false, the Clipboard
Editor
+ * will not be updated with Clipboard data.
+ *
+ * @type Boolean
+ */
+ isActive : '=?',
Review Comment:
I don't think you need this? This `scope` in the directive config is used
for passing arguments to the directive - which you're not doing that I can see.
You can just set stuff directly on `$scope` in the controller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
