Github user necouchman commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/131#discussion_r106824453
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/user/UserService.java
---
@@ -88,6 +88,7 @@ private void putAllUsers(Map<String, User> users,
LDAPConnection ldapConnection,
// Set search limits
LDAPSearchConstraints constraints = new
LDAPSearchConstraints();
constraints.setMaxResults(confService.getMaxResults());
+
constraints.setDereference(confService.getDereferenceAliases());
--- End diff --
I think that approach probably makes sense. I think this setMaxResults was
a recent-ish change to the code to allow searching on large LDAP trees and
avoid whatever built-in default existed in the JLDAP code, but I could be wrong
about that. Anyway, probably makes sense to move the constraints to a more
global area and apply them universally. I'll see what kind of progress I can
make on that...though any specific help/suggestions would be welcome.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
