Github user necouchman commented on a diff in the pull request:

    
https://github.com/apache/incubator-guacamole-client/pull/131#discussion_r106824567
  
    --- Diff: 
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ConfigurationService.java
 ---
    @@ -223,4 +223,36 @@ public int getMaxResults() throws GuacamoleException {
             );
         }
     
    +    /**
    +     * Returns whether or not LDAP aliases will be dereferenced,
    +     * as configured with guacamole.properties.
    +     * By default they will never be dereferenced.
    +     *
    +     * @return
    +     *     An integer representing the status of of alias
    +     *     dereferencing, as configured in guacamole.properties.
    +     *
    +     * @throws GuacamoleException
    +     *     If guacamole.properties cannot be parsed.
    +     */
    +    public int getDereferenceAliases() throws GuacamoleException {
    +        String derefAliases = environment.getProperty(
    +            LDAPGuacamoleProperties.LDAP_DEREFERENCE_ALIASES,
    +            "never"
    +        );
    +
    +        if (derefAliases == "always")
    +            return 3;
    --- End diff --
    
    I'll look at a couple of other implementations of LDAP clients and see what 
they do for this type of behavior.  The "finding" and "searching" terms are a 
little strange to me - I think in the past I've usually run across either two 
or three objects - usually on, off, and maybe something in between.  Four is a 
little odd...I'll have to see what the more general consensus is among LDAP 
clients.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to