Github user necouchman commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/131#discussion_r106824798
--- Diff:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ConfigurationService.java
---
@@ -223,4 +223,36 @@ public int getMaxResults() throws GuacamoleException {
);
}
+ /**
+ * Returns whether or not LDAP aliases will be dereferenced,
+ * as configured with guacamole.properties.
+ * By default they will never be dereferenced.
+ *
+ * @return
+ * An integer representing the status of of alias
+ * dereferencing, as configured in guacamole.properties.
+ *
+ * @throws GuacamoleException
+ * If guacamole.properties cannot be parsed.
+ */
+ public int getDereferenceAliases() throws GuacamoleException {
+ String derefAliases = environment.getProperty(
+ LDAPGuacamoleProperties.LDAP_DEREFERENCE_ALIASES,
+ "never"
--- End diff --
Yes, probably a good idea...will work on that.
I did fix the checking of the string value, in the meantime, such that it
expects one of the four values and throws an error if it doesn't get what it
expects. Still would be more elegant and proper with an enum.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
