Github user necouchman commented on a diff in the pull request:

    
https://github.com/apache/incubator-guacamole-client/pull/131#discussion_r106883642
  
    --- Diff: 
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ConfigurationService.java
 ---
    @@ -223,4 +223,36 @@ public int getMaxResults() throws GuacamoleException {
             );
         }
     
    +    /**
    +     * Returns whether or not LDAP aliases will be dereferenced,
    +     * as configured with guacamole.properties.
    +     * By default they will never be dereferenced.
    +     *
    +     * @return
    +     *     An integer representing the status of of alias
    +     *     dereferencing, as configured in guacamole.properties.
    +     *
    +     * @throws GuacamoleException
    +     *     If guacamole.properties cannot be parsed.
    +     */
    +    public int getDereferenceAliases() throws GuacamoleException {
    +        String derefAliases = environment.getProperty(
    +            LDAPGuacamoleProperties.LDAP_DEREFERENCE_ALIASES,
    +            "never"
    --- End diff --
    
    Okay, the latest commit takes a stab at an implementation of the new enum 
property.  I referenced the EncryptionMethod and EncryptionMethodProperty 
classes in doing the implementation.  It's slightly different since I'm mapping 
actual values for the JLDAP library instead of using encryption method to 
determine default port, but I think it'll do the trick.
    
    Also, I looked up the OpenLDAP values for the DEREF setting in ldap.conf, 
and it matches JLDAP exactly, so I'm going to stick with the 
never/searching/finding/always values at this point in time, unless someone 
would like to suggest other options.  Looks like it's more standard than I have 
experienced - I usually just toggle between never and always.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to