Github user necouchman commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/118#discussion_r145795696
--- Diff: src/protocols/ssh/client.c ---
@@ -70,8 +70,14 @@ int guac_ssh_client_free_handler(guac_client* client) {
/* Free terminal (which may still be using term_channel) */
if (ssh_client->term != NULL) {
- guac_terminal_free(ssh_client->term);
+ /* Close user input pipe to stop reading in ssh_input_thread */
+ close(ssh_client->term->stdin_pipe_fd[1]);
+ close(ssh_client->term->stdin_pipe_fd[0]);
+ ssh_client->term->stdin_pipe_fd[1] = -1;
+ ssh_client->term->stdin_pipe_fd[0] = -1;
+
--- End diff --
Why not just leave the call to guac_terminal_free here? Doesn't that
function do exactly the same thing that you're manually doing here? It seems
like this is a violation of abstraction (I made that term up) here to be
manually modifying the data members of the terminal object rather than letting
the methods in terminal.c handle that.
---
