[GitHub] incubator-guacamole-server pull request #118: GUACAMOLE-384: fixing segfault...

[necouchman]

Github user necouchman commented on a diff in the pull request:

    
https://github.com/apache/incubator-guacamole-server/pull/118#discussion_r145840867
  
    --- Diff: src/terminal/terminal.c ---
    @@ -413,8 +413,10 @@ guac_terminal* guac_terminal_create(guac_client* 
client,
     void guac_terminal_free(guac_terminal* term) {
     
         /* Close user input pipe */
    -    close(term->stdin_pipe_fd[1]);
    -    close(term->stdin_pipe_fd[0]);
    +    if (term->stdin_pipe_fd[1] != -1)
    --- End diff --
    
    Yeah, that would probably be fine.


---