Github user necouchman commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/118#discussion_r145795321
--- Diff: src/terminal/terminal.c ---
@@ -413,8 +413,10 @@ guac_terminal* guac_terminal_create(guac_client*
client,
void guac_terminal_free(guac_terminal* term) {
/* Close user input pipe */
- close(term->stdin_pipe_fd[1]);
- close(term->stdin_pipe_fd[0]);
+ if (term->stdin_pipe_fd[1] != -1)
--- End diff --
Instead of assigning -1 here, would it be better to do a fstat() call and
check the return value? It seems a little bit odd to me to be manually
assigning -1 to this variable above in client.c and then checking it here.
@mike-jumper Thoughts?
---
