Github user necouchman commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/118#discussion_r145800728
--- Diff: src/terminal/terminal.c ---
@@ -413,8 +413,10 @@ guac_terminal* guac_terminal_create(guac_client*
client,
void guac_terminal_free(guac_terminal* term) {
/* Close user input pipe */
- close(term->stdin_pipe_fd[1]);
- close(term->stdin_pipe_fd[0]);
+ if (term->stdin_pipe_fd[1] != -1)
--- End diff --
Fair enough. I suggested `fstat()`, not necessarily because of any
interest in the object returned, but because you could check the return value
of the call for something like EBADF to see if the file descriptor is still
valid/open or not. But, if `-1` is generally accepted, then I have no problem
with that.
---
