On Mon, Oct 23, 2017 at 11:25 AM, Nick Couchman <[email protected]> wrote:
>>
>> I would be in favor of finalizing scope for 0.9.14-incubating. There's
>> quite a few changes ready, and several others waiting only on review
>> or documentation:
>>
>> https://issues.apache.org/jira/issues/?jql=project%20%
>> 3D%20Guacamole%20AND%20fixVersion%20%3D%200.9.14-incubating
>>
>> ...
>>
>> I definitely don't think I'll have the X.Org driver ready for merge by
>> 0.9.14, so I've removed the version tag from the JIRA issue.
>>
>
> Sounds good. On a side note, I'm curious what progress you've made on this
> and what state it is in?
>
The X.Org driver works pretty darn well and is stable. It's the first
part of guacamole-server to fully leverage the client-side compositing
features of the Guacamole protocol for things like window movement, so
things which would normally not be that fast are quite fast and
smooth. In terms of readiness for merge, it's missing documentation,
particularly at the code level. I wrote much of the driver years ago
before we had more strict standards for code documentation, and it
needs to be brought up to spec.
In terms of functionality, the main thing lacking at the moment is
support for the "RENDER" extension, which prevents certain
applications from functioning correctly. That's not a blocker overall,
though.
As for outstanding JIRA issues vs. the 0.9.14-incubating release scope:
>...
>
> == Should be included in 0.9.14-incubating ==
> GUACAMOLE-416: Missing SQL Server translations - should be trivial to fix
> GUACAMOLE-412: Regression in Extensions without UserContext - not entirely
> sure how much is remaining here, but should be doable.
> GUACAMOLE-394: Record User Login/Logout - this is pretty much done, right?
> GUACAMOLE-296: Disconnect on audio redirection - I need to see if I can
> nail this one down.
> GUACAMOLE-210: OpenID SSO Authentication - completed, I believe?
> GUACAMOLE-243: Fix issue with LDAP referrals - currently not on the
> 0.9.14-incubating release list, but really needs to be merged. Ready for
> review.
I agree on all these.
OpenID SSO is complete, but I need to update the manual.
User login/logout logging is complete, but there are a couple branches
worth of changes which need to be updated with the addition of SQL
server support. Once those are reviewed and merged, I'll have to
update the schema portion of the manual, but that should be pretty
easy.
>
> == Tagged for 0.9.14, but can go either way ==
> GUACAMOLE-415: Support for SQLite Authentication - still in need of review
> GUACAMOLE-197: Support for RADIUS Authentication - needs to finish up review
>
In light of the RADIUS-related bug, and the known wonkiness of the
SQLite implementation, I'd say let's just exclude these from scope.
> == Not currently tagged for any release, up for discussion ==
> GUACAMOLE-38: Support for Ad-Hoc connections ("QuickConnect") - in need of
> review
> GUACAMOLE-221: Support for connection prompts - won't be ready for 0.9.14,
> needs review and probably a lot of work
These are relatively complex changes. In the interest of narrow scope,
I don't think these should be in 0.9.14-incubating.
> GUACAMOLE-396: Support for CAS ClearPass - probably could be ready for
> 0.9.14, just needs a few more tweaks and review
> GUACAMOLE-355: Improved CAS error handling - should be close
I'm happy with both of these CAS-related issues being part of
0.9.14-incubating scope.
> GUACAMOLE-350: Increased SSH key size support - Needs a new PR and review,
> but should be close
>
There may be some hidden scariness here with respect to SQL server and
differing varchar column limits between versions, but I would be happy
with this in 0.9.14-incubating scope, as well.
- Mike
