> > > As the fix within #118 for GUACAMOLE-384 (a low-impact segfault during > disconnect) involves changing the order resources are freed prior to > joining on the SSH client thread, there is the potential here for a > regression resulting in deadlock, which would affect the stability of > the Guacamole server overall as stale connection processes pile up. As > much as it hurts the eyes to see that segfault, it doesn't affect the > stability of connections since it occurs only during disconnect. > > Given the severity of such a regression, I would be against expanding > established 0.9.14-incubating scope to cover GUACAMOLE-384. The fix > needs more testing, particularly on other platforms, to ensure that > things do unblock as expected, that something else wasn't overlooked > during review that could lead to deadlock, etc. > > - Mike >
Okay, sounds good. -Nick
