> On 2010-06-11 15:31:37, stack wrote: > > src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCleaner.java, > > line 56 > > <http://review.hbase.org/r/76/diff/5/?file=1114#file1114line56> > > > > For sure setConf will have been called before we get here? So, stuff > > gets setup by setConf? Can setConf be called more than once? How do I > > know how to use this class? Not doc'd. Doesn't have a Constructor.
LogCleanerDelegate is the interface that defines the general behavior. Yes should have a constructor. > On 2010-06-11 15:31:37, stack wrote: > > src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCleaner.java, > > line 111 > > <http://review.hbase.org/r/76/diff/5/?file=1114#file1114line111> > > > > The way this is done, if I didn't want to wait on the ttl, then I'd > > have to write a new class. Can't we have ttl and recplication be distinct > > and then if I want delete based off ttl and whether log up in zk, then > > chain them? I don't follow, chaining is already how I do it. > On 2010-06-11 15:31:37, stack wrote: > > src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java, > > line 54 > > <http://review.hbase.org/r/76/diff/5/?file=1116#file1116line54> > > > > I dont follow? Yeah, RepSink is a mix of 2 solutions but only features the worst of both. The next patch will significantly make it better. > On 2010-06-11 15:31:37, stack wrote: > > src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java, > > line 126 > > <http://review.hbase.org/r/76/diff/5/?file=1117#file1117line126> > > > > This ain't a constructor? I ain't.. but it's used like one. > On 2010-06-11 15:31:37, stack wrote: > > src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java, > > line 483 > > <http://review.hbase.org/r/76/diff/5/?file=1117#file1117line483> > > > > We have to copy? This is the down side of the way of I'm caping the log entries by size or number. I'm reusing the same HLog.Entry[] entriesArray to read from HLogs (and the entries in it). For example, replicationQueueSizeCapacity=64MB and replicationQueueNbCapacity=25k. Let's say on a first run we reach 25k without reaching the size, so we'll replicate the whole array. Now on the second run let's say we reached 64MB after only 10k rows, then we only want to replicate that and not the 15k "leftovers". > On 2010-06-11 15:31:37, stack wrote: > > src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java, > > line 67 > > <http://review.hbase.org/r/76/diff/5/?file=1123#file1123line67> > > > > No dfs in this test. Thats intentional? Nope, should fix. > On 2010-06-11 15:31:37, stack wrote: > > src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java, > > line 86 > > <http://review.hbase.org/r/76/diff/5/?file=1124#file1124line86> > > > > Can't you squash some of these tests together? They each start up own > > minidfscluster... just start it once? They don't? @Before public void setUp() throws Exception { table1 = TEST_UTIL.truncateTable(TABLE_NAME1); table2 = TEST_UTIL.truncateTable(TABLE_NAME2); Thread.sleep(SLEEP_TIME); } - Jean-Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/76/#review194 ----------------------------------------------------------- On 2010-06-08 17:54:19, Jean-Daniel Cryans wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/76/ > ----------------------------------------------------------- > > (Updated 2010-06-08 17:54:19) > > > Review request for hbase. > > > Summary > ------- > > This is HBASE-2223 AKA Replication 2.0, it is currently only a "preview > patch" as it's pretty much feature complete, works on a cluster, has unit > tests and whatnot, but it could use a lot more testing and cleaning and ideas > from others. > > > This addresses bug HBASE-2223. > http://issues.apache.org/jira/browse/HBASE-2223 > > > Diffs > ----- > > bin/replication/add_peer.rb PRE-CREATION > bin/replication/copy_tables_desc.rb PRE-CREATION > pom.xml 03c6ec8 > src/main/java/org/apache/hadoop/hbase/HConstants.java 13aff26 > src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java b36f1df > src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 82148a6 > src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > a1baff4 > src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 034690e > src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogKey.java 5d4cffe > > src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java > PRE-CREATION > > src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCleaner.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/replication/package.html PRE-CREATION > > src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java > PRE-CREATION > > src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java > PRE-CREATION > > src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceInterface.java > PRE-CREATION > > src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java > PRE-CREATION > src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 2f2f306 > > src/test/java/org/apache/hadoop/hbase/replication/ReplicationSourceDummy.java > PRE-CREATION > src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java > PRE-CREATION > > Diff: http://review.hbase.org/r/76/diff > > > Testing > ------- > > > Thanks, > > Jean-Daniel > >
