-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/76/#review297
-----------------------------------------------------------

Ship it!


+1 on commit if all tests pass.  I sat wé J-D and went over the changes.  All 
is good for first commit.

- stack


On 2010-06-30 15:36:59, Jean-Daniel Cryans wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/76/
> -----------------------------------------------------------
> 
> (Updated 2010-06-30 15:36:59)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> This is HBASE-2223 AKA Replication 2.0, it is currently only a "preview 
> patch" as it's pretty much feature complete, works on a cluster, has unit 
> tests and whatnot, but it could use a lot more testing and cleaning and ideas 
> from others.
> 
> 
> This addresses bug HBASE-2223.
>     http://issues.apache.org/jira/browse/HBASE-2223
> 
> 
> Diffs
> -----
> 
>   bin/replication/add_peer.rb PRE-CREATION 
>   bin/replication/copy_tables_desc.rb PRE-CREATION 
>   pom.xml 400cc0c 
>   src/main/java/org/apache/hadoop/hbase/HConstants.java 4357ee5 
>   src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 62617ac 
>   src/main/java/org/apache/hadoop/hbase/master/HMaster.java 04bc95e 
>   src/main/java/org/apache/hadoop/hbase/master/LogCleanerDelegate.java 
> 4c5153e 
>   src/main/java/org/apache/hadoop/hbase/master/OldLogsCleaner.java 07e69b4 
>   src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 
> 33b9a99 
>   src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 94f18c6 
>   src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogKey.java 5d4cffe 
>   
> src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperWrapper.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCleaner.java
>  PRE-CREATION 
>   src/main/java/org/apache/hadoop/hbase/replication/package.html PRE-CREATION 
>   
> src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceInterface.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
>  PRE-CREATION 
>   src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java 
> b26c071 
>   src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java d865e38 
>   src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java 
> e96637f 
>   
> src/test/java/org/apache/hadoop/hbase/replication/ReplicationSourceDummy.java 
> PRE-CREATION 
>   src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java
>  PRE-CREATION 
> 
> Diff: http://review.hbase.org/r/76/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jean-Daniel
> 
>

Reply via email to