> On 2010-06-25 15:07:35, stack wrote: > > src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java, > > line 149 > > <http://review.hbase.org/r/76/diff/7/?file=1590#file1590line149> > > > > Duplicated code -- see up about ten lines. > > Jean-Daniel Cryans wrote: > Not it's different, one inserts and the other deletes
Ok oh yeah there is a better way to do it. - Jean-Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/76/#review281 ----------------------------------------------------------- On 2010-06-23 17:24:52, Jean-Daniel Cryans wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://review.hbase.org/r/76/ > ----------------------------------------------------------- > > (Updated 2010-06-23 17:24:52) > > > Review request for hbase. > > > Summary > ------- > > This is HBASE-2223 AKA Replication 2.0, it is currently only a "preview > patch" as it's pretty much feature complete, works on a cluster, has unit > tests and whatnot, but it could use a lot more testing and cleaning and ideas > from others. > > > This addresses bug HBASE-2223. > http://issues.apache.org/jira/browse/HBASE-2223 > > > Diffs > ----- > > bin/replication/add_peer.rb PRE-CREATION > bin/replication/copy_tables_desc.rb PRE-CREATION > src/main/java/org/apache/hadoop/hbase/HConstants.java 4357ee5 > src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 62617ac > src/main/java/org/apache/hadoop/hbase/master/HMaster.java 5367638 > src/main/java/org/apache/hadoop/hbase/master/LogCleanerDelegate.java > 4c5153e > > src/main/java/org/apache/hadoop/hbase/master/RegionServerOperationQueue.java > 10f9dbd > src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 9fb1cce > src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > 33b9a99 > src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 94f18c6 > src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogKey.java 5d4cffe > > src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperWrapper.java > PRE-CREATION > > src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCleaner.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/replication/package.html PRE-CREATION > > src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java > PRE-CREATION > > src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java > PRE-CREATION > > src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceInterface.java > PRE-CREATION > > src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java > PRE-CREATION > src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWrapper.java > b26c071 > src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 0e69709 > > src/test/java/org/apache/hadoop/hbase/replication/ReplicationSourceDummy.java > PRE-CREATION > src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java > PRE-CREATION > > src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java > PRE-CREATION > > Diff: http://review.hbase.org/r/76/diff > > > Testing > ------- > > > Thanks, > > Jean-Daniel > >
