----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/76/ -----------------------------------------------------------
(Updated 2010-06-17 12:57:07.815144) Review request for hbase. Changes ------- Patch rebased on the new Zookeeper/Master and with a cleaned up ReplicationSink. Also some cleanup from Stack's comments. Currently fails TestReplication, hitting https://issues.apache.org/jira/browse/HBASE-2741 that kills a master thread. The root cause could be in this code but the NPE doesn't help debugging. Summary ------- This is HBASE-2223 AKA Replication 2.0, it is currently only a "preview patch" as it's pretty much feature complete, works on a cluster, has unit tests and whatnot, but it could use a lot more testing and cleaning and ideas from others. This addresses bug HBASE-2223. http://issues.apache.org/jira/browse/HBASE-2223 Diffs (updated) ----- bin/replication/add_peer.rb PRE-CREATION bin/replication/copy_tables_desc.rb PRE-CREATION src/main/java/org/apache/hadoop/hbase/HConstants.java f5d3e94 src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 62617ac src/main/java/org/apache/hadoop/hbase/master/HMaster.java 66dc697 src/main/java/org/apache/hadoop/hbase/master/LogCleanerDelegate.java 4c5153e src/main/java/org/apache/hadoop/hbase/master/RegionServerOperationQueue.java 10f9dbd src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 1d95258 src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 7ace16a src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 05cf17f src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogKey.java 5d4cffe src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCleaner.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/replication/package.html PRE-CREATION src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceInterface.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java PRE-CREATION src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 04957ca src/test/java/org/apache/hadoop/hbase/replication/ReplicationSourceDummy.java PRE-CREATION src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java PRE-CREATION src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java PRE-CREATION src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java PRE-CREATION src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java PRE-CREATION Diff: http://review.hbase.org/r/76/diff Testing ------- Thanks, Jean-Daniel
