GitHub user overquota opened a pull request:
https://github.com/apache/httpcomponents-client/pull/103
fixed incorrect connection close on shutdown + fixed corresponding test
due to https://issues.apache.org/jira/browse/HTTPCLIENT-1923
close() method was changed due to Oleg@ suggestion
But thats was not enough, because it isnt called at all when connection
manager is shutting down [entering in connection manager shutdown on client
close](https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient/src/main/java/org/apache/http/impl/client/HttpClientBuilder.java#L1233)
-> [shutdown method
called](https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient/src/main/java/org/apache/http/impl/conn/BasicHttpClientConnectionManager.java#L376)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/overquota/httpcomponents-client 4.5.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/httpcomponents-client/pull/103.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #103
----
commit ebada8ff73cc70053a0462dd549ffcd687f3e6ee
Author: Aleksei Arsenev <aarseniev@...>
Date: 2018-05-11T10:14:47Z
fixed incorrect connection close on shutdown + fixed corresponding test
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
