Github user ok2c commented on a diff in the pull request:

    
https://github.com/apache/httpcomponents-client/pull/103#discussion_r187595171
  
    --- Diff: 
httpclient/src/main/java/org/apache/http/impl/conn/BasicHttpClientConnectionManager.java
 ---
    @@ -375,7 +375,7 @@ public synchronized void closeIdleConnections(final 
long idletime, final TimeUni
         @Override
         public synchronized void shutdown() {
             if (this.isShutdown.compareAndSet(false, true)) {
    -            shutdownConnection();
    --- End diff --
    
    @overquota I am not sure I agree. `#shutdown` is supposed to be used to 
execute an abnormal connection termination (with `RST`), while `#close` is to 
be used for orderly connection termination (with `FIN+ACK`). 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to