Github user overquota commented on a diff in the pull request:
https://github.com/apache/httpcomponents-client/pull/103#discussion_r187594314
--- Diff:
httpclient/src/main/java/org/apache/http/impl/conn/BasicHttpClientConnectionManager.java
---
@@ -375,7 +375,7 @@ public synchronized void closeIdleConnections(final
long idletime, final TimeUni
@Override
public synchronized void shutdown() {
if (this.isShutdown.compareAndSet(false, true)) {
- shutdownConnection();
--- End diff --
I think no because `#shutdownConnection` closes connection with `RST`
(https://github.com/apache/httpcomponents-core/blob/4.4.x/httpcore/src/main/java/org/apache/http/impl/BHttpConnectionBase.java#L304)
- this is not normal tcp connection closing
While `#closeConnection` doing it more correctly (FIN+ACK):
https://github.com/apache/httpcomponents-core/blob/4.4.x/httpcore/src/main/java/org/apache/http/impl/BHttpConnectionBase.java#L315
`#shutdown` may do `#shutdownConnection` only if `#shutdownConnection` will
do close() on connection instance i think... but if so - i think there are no
difference what shutdown method will do close instead of shutdown =)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
