Github user overquota commented on a diff in the pull request:
https://github.com/apache/httpcomponents-client/pull/103#discussion_r187599165
--- Diff:
httpclient/src/main/java/org/apache/http/impl/conn/BasicHttpClientConnectionManager.java
---
@@ -375,7 +375,7 @@ public synchronized void closeIdleConnections(final
long idletime, final TimeUni
@Override
public synchronized void shutdown() {
if (this.isShutdown.compareAndSet(false, true)) {
- shutdownConnection();
--- End diff --
just for example:
`#shutdown` in
[PoolingHttpClientConnectionManager](https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient/src/main/java/org/apache/http/impl/conn/PoolingHttpClientConnectionManager.java#L410)
really do `this.pool.shutdown();`
*BUT*
`this.pool.shutdown` doing
[entry.close](https://github.com/apache/httpcomponents-core/blob/4.4.x/httpcore/src/main/java/org/apache/http/pool/AbstractConnPool.java#L148)
- which is the same normal `conn.close()`
In addition:
[HttpClientBuilder](https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient/src/main/java/org/apache/http/impl/client/HttpClientBuilder.java#L1232)
knows only about `#close`, and on close it is doing... `#shutdown` :) - thats
the main reason i've changed `#shutdown` method
In addition 2: [ClientConnectionManager
declaration](https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient/src/main/java/org/apache/http/conn/ClientConnectionManager.java#L112)
does not know anything about `#close`, only `#shutdown`. And there are no docs
about how connections would be terminated
Do you want me to refactor all these misleadings? No problems, really, but
I don't know is it worth it?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
