Yaliang commented on a change in pull request #2847: Replace CHECK() with
CHECK_*() so that when a check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179627824
##########
File path: heron/common/src/cpp/zookeeper/zkclient.cpp
##########
@@ -131,7 +131,7 @@ ZKClient::ZKClient(const std::string& hostportlist,
EventLoop* eventLoop,
: eventLoop_(eventLoop),
hostportlist_(hostportlist),
client_global_watcher_cb_(std::move(global_watcher_cb)) {
- CHECK(client_global_watcher_cb_);
+ CHECK(client_global_watcher_cb_) << "Client global watcher is not provided";
Review comment:
I think it's better to explicitly say it's a callback
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
