Yaliang commented on a change in pull request #2847: Replace CHECK() with
CHECK_*() so that when a check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179631189
##########
File path: heron/stmgr/src/cpp/util/xor-manager.cpp
##########
@@ -59,17 +59,17 @@ void XorManager::rotate(EventLoopImpl::Status) {
}
void XorManager::create(sp_int32 _task_id, sp_int64 _key, sp_int64 _value) {
- CHECK(tasks_.find(_task_id) != tasks_.end());
+ CHECK(tasks_.find(_task_id) != tasks_.end()) << "Task " << _task_id << " is
not found";
Review comment:
I would prefer `Failed to find Task xxx`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
