Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more … URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179630646
########## File path: heron/tmaster/src/cpp/manager/tmaster.cpp ########## @@ -116,7 +116,7 @@ TMaster::TMaster(const std::string& _zk_hostport, const std::string& _topology_n tmaster_location_->set_controller_port(tmaster_controller_port_); tmaster_location_->set_master_port(master_port_); tmaster_location_->set_stats_port(stats_port_); - DCHECK(tmaster_location_->IsInitialized()); + DCHECK(tmaster_location_->IsInitialized()) << "TMaster local is not initialized"; Review comment: location? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
