Yaliang commented on a change in pull request #2847: Replace CHECK() with
CHECK_*() so that when a check is failing, more …
URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179630977
##########
File path: heron/tmaster/src/cpp/manager/stateful-restorer.cpp
##########
@@ -71,7 +71,7 @@ void StatefulRestorer::HandleStMgrRestored(const
std::string& _stmgr_id,
void StatefulRestorer::Finish2PhaseCommit(const StMgrMap& _stmgrs) {
LOG(INFO) << "Finishing Stateful 2 Phase Commit since all stmgrs have
replied back";
- CHECK(unreplied_stmgrs_.empty());
+ CHECK(unreplied_stmgrs_.empty()) << "Unreplied stmgrs are found when
finishing 2-phrase commit";
Review comment:
Write stmgres full name name and use `Stateful 2 Phase Commit`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
