----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56763/#review165914 -----------------------------------------------------------
Thanks for the patch! As discussed in the jira it would be good to hide username/password in the logs. I have found 3 places where we might be a problem. Otherwise the patch looks good to me. Even run the upcoming Yetus check on it (HIVE-15051), and it did not produce any errors, which is rare :) Thanks again, Peter jdbc/src/java/org/apache/hive/jdbc/Utils.java (line 301) <https://reviews.apache.org/r/56763/#comment237758> As discussed in the jira, it would be good to remove username/password from the url before logging it out jdbc/src/java/org/apache/hive/jdbc/Utils.java (line 304) <https://reviews.apache.org/r/56763/#comment237759> as above jdbc/src/java/org/apache/hive/jdbc/Utils.java (line 463) <https://reviews.apache.org/r/56763/#comment237760> as above jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java (line 97) <https://reviews.apache.org/r/56763/#comment237761> Just a question: Why we are removing the message? Was it missleading in some case? - Peter Vary On Feb. 16, 2017, 6:22 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56763/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2017, 6:22 p.m.) > > > Review request for hive, Peter Vary and Thejas Nair. > > > Bugs: HIVE-15931 > https://issues.apache.org/jira/browse/HIVE-15931 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-15931 > > > Diffs > ----- > > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 535ad3d > jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java a349f8b > jdbc/src/java/org/apache/hive/jdbc/Utils.java bfae8b9 > jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java 8d6003a > > Diff: https://reviews.apache.org/r/56763/diff/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
