> On March 16, 2017, 9:27 p.m., Peter Vary wrote: > > jdbc/src/java/org/apache/hive/jdbc/Utils.java > > Lines 423-426 (patched) > > <https://reviews.apache.org/r/56763/diff/3-4/?file=1665965#file1665965line423> > > > > I think you will kick me around after this. Most probably I was not > > clear enough what I ment with my comment. > > > > The HIDDEN_CONF_LIST contains configuration keys, which values should > > be kept secret. (Comma separated list of configuration options which should > > not be read by normal user like passwords) > > > > So I was thinkig about somethig like this: > > // Remove hive.conf.hidden.list values > > for (String entry : HiveConfUtil.getHiddenSet(conf)) { > > anonymizedUriString = anonymizedUriString.replaceAll("(?i)" + entry + > > "=[^;?#]*", entry + "=xxxxx"); > > } > > > > Only when I wrote down the code did I realize, that we are on the > > client side so we can not use this configuration value. > > Sorry for the extra rounds. This should be removed.
Actually it's good to remove that from logging because a client can pass hive conf parameters from client side as well (https://github.com/apache/hive/blob/master/jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java#L148). > On March 16, 2017, 9:27 p.m., Peter Vary wrote: > > jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver.java > > Lines 102 (patched) > > <https://reviews.apache.org/r/56763/diff/4/?file=1666381#file1666381line102> > > > > This test is Parameterized. So this test will be run 9 times in a row. > > I suggest to move this test to a new test class. Thanks for pointing out. I am more inclined in moving it to TestJdbcDriver2 which was intended to have JDBC driver only test but over the time pulled in other stuff. TestJdbcWithMiniHS2 is ideally where the client-server integration should live; however we can keep that cleanup for later. - Vaibhav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56763/#review169212 ----------------------------------------------------------- On March 16, 2017, 7:51 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56763/ > ----------------------------------------------------------- > > (Updated March 16, 2017, 7:51 p.m.) > > > Review request for hive, Peter Vary and Thejas Nair. > > > Bugs: HIVE-15931 > https://issues.apache.org/jira/browse/HIVE-15931 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-15931 > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/Commands.java 99ee82c > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java > 4a82aa5 > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 1695c5d > jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java a349f8b > jdbc/src/java/org/apache/hive/jdbc/Utils.java bfae8b9 > jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java 8d6003a > jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver.java 162e42f > > > Diff: https://reviews.apache.org/r/56763/diff/4/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
