----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56763/#review169212 -----------------------------------------------------------
Thanks, and sorry for the extra rounds. Peter jdbc/src/java/org/apache/hive/jdbc/Utils.java Lines 423-426 (patched) <https://reviews.apache.org/r/56763/#comment241547> I think you will kick me around after this. Most probably I was not clear enough what I ment with my comment. The HIDDEN_CONF_LIST contains configuration keys, which values should be kept secret. (Comma separated list of configuration options which should not be read by normal user like passwords) So I was thinkig about somethig like this: // Remove hive.conf.hidden.list values for (String entry : HiveConfUtil.getHiddenSet(conf)) { anonymizedUriString = anonymizedUriString.replaceAll("(?i)" + entry + "=[^;?#]*", entry + "=xxxxx"); } Only when I wrote down the code did I realize, that we are on the client side so we can not use this configuration value. Sorry for the extra rounds. This should be removed. jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver.java Lines 102 (patched) <https://reviews.apache.org/r/56763/#comment241548> This test is Parameterized. So this test will be run 9 times in a row. I suggest to move this test to a new test class. - Peter Vary On March 16, 2017, 7:51 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56763/ > ----------------------------------------------------------- > > (Updated March 16, 2017, 7:51 p.m.) > > > Review request for hive, Peter Vary and Thejas Nair. > > > Bugs: HIVE-15931 > https://issues.apache.org/jira/browse/HIVE-15931 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-15931 > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/Commands.java 99ee82c > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java > 4a82aa5 > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 1695c5d > jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java a349f8b > jdbc/src/java/org/apache/hive/jdbc/Utils.java bfae8b9 > jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java 8d6003a > jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver.java 162e42f > > > Diff: https://reviews.apache.org/r/56763/diff/4/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
