----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56763/#review169107 -----------------------------------------------------------
Thanks for the changes Vaibhav! Good catch with the BeeLine logs! After seeing this I realized that the connection URL still might be logged to the configuration and to the history, but I think that is another story and should not be part of this change. Found an existing jira for it (HIVE-13091) Just 1 question and minor nits. Otherwise LGTM (non-binding). Thanks, Peter jdbc/src/java/org/apache/hive/jdbc/Utils.java Line 396 (original), 396 (patched) <https://reviews.apache.org/r/56763/#comment241425> Just a question: So we decided, that not remove HIVE_CONF_HIDDEN_LIST configuration values from the URL? itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java Lines 1872 (patched) <https://reviews.apache.org/r/56763/#comment241424> nit: This is not really an integration test, so I think we should put this into the jdbc module instead. nit: Your regexps in Utils.anonymizeUriString are correct, but it might be worth to put another name/value pair into the test url and validate that it was not removed, ensuring that if somebody changes the original method it will not accidentally hide everything :). What do you think? - Peter Vary On March 16, 2017, 2:51 a.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56763/ > ----------------------------------------------------------- > > (Updated March 16, 2017, 2:51 a.m.) > > > Review request for hive, Peter Vary and Thejas Nair. > > > Bugs: HIVE-15931 > https://issues.apache.org/jira/browse/HIVE-15931 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-15931 > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/Commands.java 99ee82c > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java > 4a82aa5 > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 1695c5d > jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java a349f8b > jdbc/src/java/org/apache/hive/jdbc/Utils.java bfae8b9 > jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java 8d6003a > > > Diff: https://reviews.apache.org/r/56763/diff/3/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
