On Tue, 4 Oct 2011, Daniel Ruggeri wrote:
On 10/4/2011 2:12 PM, Graham Leggett wrote:
On 04 Oct 2011, at 8:00 PM, Stefan Fritsch wrote:
I think this one has been controversial in the past, therefore I
thought I'd ask for comments before making this change:
The "File does not exist" log messages are logged at level error,
while not providing additional information over the 404 access log
line (at least in many setups). There have been requests to lower the
loglevel for these messages (PR 35768), which have been denied in the
past because of compatibility and "it's an error". The per-module
loglevels help not much, because most of the "File does not exist"
messages come from core, and one usually does not want to set
LogLevel core:crit.
I therefore intend to add a LogLevelFileNotFound config directive
that allows to make it configurable and a "int
ap_loglevel_file_not_found(request_rec *)" API that allows modules to
query the setting. I think per-virtual server would be enough for the
setting, but with this API that could be changed to per-dir later on.
Hmmm... it seems unclean to me and counterintuitive.
Definitely unclean. From the comments in the PR I got the impression that
changing the loglevel was not an option. But I would definitely prefer
changing it rather than adding an additional directive.
How about moving the default_handler() into the http module?
Big +1 on achieving this objective. One question, though, about moving
the handler into http... Does that also imply adjusting the logging
level by using http:crit? Wouldn't we swallow several other important
messages by changing logging levels there?
Yes, IMO moving the default_handler around doesn't solve the problem (and
similar messages are logged by mod_action and mod_asis at level error,
too). Besides, default_handler() mostly deals with stuff from
core_dir_config. It's not obvious that it would fit better in
mod_http, IMHO.
