Meh.

Stefan: once during the last 2 days or several?


This is accessing r->useragent_addr by mod_access_compat which is, for h2 
slaves, initialized with c->client_addr.

Since c->client_addr is always initialized by the master connection, I did not 
see any race issues with sharing this across multiple slaves. Anyone has an 
idea?

> Am 24.02.2017 um 12:33 schrieb Stefan Priebe - Profihost AG 
> <s.pri...@profihost.ag>:
> 
> Hi Yann,
>  Hi Stefan,
> 
> new trace:
> Core was generated by `/usr/local/apache/bin/httpd -DFOREGROUND'.
> Program terminated with signal SIGSEGV, Segmentation fault.
> #0  0x00007f459699740c in apr_ipsubnet_test (ipsub=0x7f44c003d070,
>    sa=0x7f4570021950) at network_io/unix/sockaddr.c:1090
> #0  0x00007f459699740c in apr_ipsubnet_test (ipsub=0x7f44c003d070,
>    sa=0x7f4570021950) at network_io/unix/sockaddr.c:1090
> #1  0x00007f459573b400 in find_allowdeny (r=r@entry=0x7f44c002c250,
>    method=method@entry=0, a=<optimized out>, a=<optimized out>)
>    at mod_access_compat.c:270
> #2  0x00007f459573b59a in check_dir_access (r=0x7f44c002c250)
>    at mod_access_compat.c:324
> #3  0x0000560ce8333fd0 in ap_run_access_checker (r=0x7f44c002c250)
>    at request.c:87
> #4  0x0000560ce8336ea8 in ap_process_request_internal (r=0x7f44c002c250)
>    at request.c:265
> #5  0x0000560ce8377b40 in ap_process_async_request (r=0x7f44c002c250)
>    at http_request.c:434
> #6  0x0000560ce8377cf0 in ap_process_request (r=0x7f44c002c250)
>    at http_request.c:471
> #7  0x0000560ce83b8aad in h2_task_process_request (c=<optimized out>,
>    task=<optimized out>) at h2_task.c:612
> #8  h2_task_process_conn (c=0x7f44c003d070) at h2_task.c:659
> #9  0x0000560ce8347fd0 in ap_run_process_connection (c=0x7f44c0026220)
>    at connection.c:42
> #10 0x0000560ce83b9eaf in h2_task_do (task=0x7f44c002a240,
>    thread=0x560ce8afc900, worker_id=365015362) at h2_task.c:578
> #11 0x0000560ce83c362f in execute (thread=0x560ce8afc900,
> wctx=0x560ce8afc8c0)
>    at h2_worker.c:46
> #12 0x00007f45967610a4 in start_thread ()
>   from /lib/x86_64-linux-gnu/libpthread.so.0
> #13 0x00007f459649662d in clone () from /lib/x86_64-linux-gnu/libc.so.6
> 
> Stefan
> 
> Am 23.02.2017 um 07:59 schrieb Stefan Priebe - Profihost AG:
>> Am 22.02.2017 um 12:22 schrieb Yann Ylavic:
>>> Hi Stefan,
>>> 
>>> On Wed, Feb 22, 2017 at 11:32 AM, Stefan Priebe - Profihost AG
>>> <s.pri...@profihost.ag> wrote:
>>>> 
>>>> @Yann how should i test? Vanilla 2.4.25 + MPM V7 + mod_http2 v1.9.1?
>>> 
>>> Yes, I think this is the right thing to do for now (no more patches than 
>>> v7).
>>> 
>>>> Or
>>>> do i need V8 or something else?
>>> 
>>> Not ready yet, I'll propose it when that's the case if you can test it then.
>>> That's an mpm_event optimization (hopefully) only, v7 is good from
>>> correctness POV...
>> 
>> OK it's running. Will report back.
>> 
>> Greets,
>> Stefan
>> 
>>> Thanks for testing, still!
>>> 
>>> Regards,
>>> Yann.
>>> 

Stefan Eissing

<green/>bytes GmbH
Hafenstrasse 16
48155 Münster
www.greenbytes.de

Reply via email to