> Am 08.09.2020 um 21:11 schrieb Ruediger Pluem <rpl...@apache.org>:
>
>
>
> On 9/8/20 9:22 AM, Stefan Eissing wrote:
>>
>>
>>> Am 08.09.2020 um 08:27 schrieb Ruediger Pluem <rpl...@apache.org>:
>>>
>>>
>>>
>>> On 8/21/20 9:20 AM, Ruediger Pluem wrote:
>>>>
>>>>
>>>> On 8/20/20 11:38 AM, Stefan Eissing wrote:
>>>>>
>>>>>
>>>>>> Am 20.08.2020 um 11:35 schrieb Ruediger Pluem <rpl...@apache.org>:
>>>>>>
>>>>>>
>>>>>>
>>>>>> On 8/20/20 10:47 AM, Stefan Eissing wrote:
>>>>>>>
>>>>>>>
>>>>>>>> Am 20.08.2020 um 10:01 schrieb Ruediger Pluem <rpl...@apache.org>:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On 8/19/20 12:18 PM, Stefan Eissing wrote:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> Am 19.08.2020 um 12:08 schrieb Ruediger Pluem <rpl...@apache.org>:
>>>>>>
>>>>
>>>>>>
>>>>>> What about:
>>>>>>
>>>>>> set_error_response would set the http_status in a not yet existing field
>>>>>> (e.g. early_status)
>>>>>> of the h2_request struct via stream->rtmp instead of creating a brigade
>>>>>> in stream->out_buffer and adding to it.
>>>>>> h2_request_create_rec could then check for this field and if non zero
>>>>>> call ap_die after doing some minimal request_rec setup.
>>>>>> I could transform this into a patch for more gory discussion if you like.
>>>>>
>>>>> ;-)
>>>>>
>>>>> a) without making the complete requests, but a special one that knows how
>>>>> to fail? Go for it!
>>>>
>>>> How about https://github.com/apache/httpd/pull/137 ?
>>>
>>>
>>> Any feedback or comments?
>>
>> Sorry about the delay, my inbox in unhealthy these days.
>
> No problem. Even more thanks then for taking time for a review.
Thanks for improving this.
>
>>
>> Had a quick look. My read: it looks like a good approach. The request still
>> needs to be processed in a worker, but that should be very light and fast. I
>> was first confused by the "early_http_status" term as there is the "103
>> early hints" intermediate response code stuck in my brain. Maybe we should
>> just call it http_status and have a HTTP_NEEDS_FURTHER_PROCESSING (0) in our
>> server.
>
> Updated the PR and renamed early_http_status to http_status.
> What do you mean with / what is the purpose of HTTP_NEEDS_FURTHER_PROCESSING?
> Should http_status be initialized with this define
> or do you want to replace conditions of the type (http_status) with
> (http_status != HTTP_NEEDS_FURTHER_PROCESSING)?
> At what place should we define it? In h2.h?
Just a thought that 0 could indicate that the http status has not been
determined yet (default) or in case of an early error the code to return. Which
then prevents further processing. The name for such a value was not entirely
serious. We could just check on != 0.
Cheers, Stefan
>
> Regards
>
> Rüdiger
