Tim Armstrong has posted comments on this change. Change subject: IMPALA-2987: Distinguish between already-closed and never-seen data stream receivers ......................................................................
Patch Set 5: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/2305/5//COMMIT_MSG Commit Message: Line 34: already_unregistered=false, and cancel). > Given the discussion in the change review, do we still believe this to be t I think the condition would be either a) the entire input is consumed or b) the query is complete and everything is being closed. It might make sense later to support an orderly Close() before the end of the query to allow freeing resources, but we don't do that now. -- To view, visit http://gerrit.cloudera.org:8080/2305 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1734992c7199b9dd4b03afca5372022051b6fbd Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.5.0_5.7.0 Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
