Henry Robinson has posted comments on this change. Change subject: IMPALA-2987: Distinguish between already-closed and never-seen data stream receivers ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/2305/5//COMMIT_MSG Commit Message: Line 34: already_unregistered=false, and cancel). > hmm, that seems bad then. what do you think we should do? I'm trying to construct a query that could have this property. It would require a limit that doesn't get pushed down - so an exchg hits its limit before a sender does. And this structure would have to be unioned with another subquery that ran for a long time. It all seems very unlikely, and potentially would have a workaround. So I think we should continue with this fix, particularly in the absence of a better solution. -- To view, visit http://gerrit.cloudera.org:8080/2305 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1734992c7199b9dd4b03afca5372022051b6fbd Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.5.0_5.7.0 Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
