Henry Robinson has posted comments on this change. Change subject: IMPALA-2987: Distinguish between already-closed and never-seen data stream receivers ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/2305/5//COMMIT_MSG Commit Message: Line 34: already_unregistered=false, and cancel). > I think the condition would be either a) the entire input is consumed or b) The precise requirement is probably that STREAM_EXPIRATION_TIME_MS needs to be high enough so that no sender tries to call TransmitData() after STREAM_EXPIRATION_TIME_MS after the receiver is closed, if the query is still running. In practice, we decided this can't happen because no receiver should Close() before consuming its input in the case where the query is still going to complete. We still need to check all the callsites of Close() to be sure of this. http://gerrit.cloudera.org:8080/#/c/2305/5/be/src/runtime/data-stream-mgr.cc File be/src/runtime/data-stream-mgr.cc: Line 45: /// higher will increase the size of the stream cache (which is 48 bytes per receiver). > In the case it doesn't outlive all calls to FindRecvrOrWait() for that stre The consequence is that the sender will return an error during TransmitData(), which should lead to query cancellation. I'll update the comment. -- To view, visit http://gerrit.cloudera.org:8080/2305 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib1734992c7199b9dd4b03afca5372022051b6fbd Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.5.0_5.7.0 Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
