Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2738 Hive/Impala inconsistency in GRANT/REVOKE syntax ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2296/2/fe/src/main/java/com/cloudera/impala/analysis/PrivilegeSpec.java File fe/src/main/java/com/cloudera/impala/analysis/PrivilegeSpec.java: Line 173: if (serverName_ == null) { : serverName_ = analyzer.getAuthzConfig().getServerName(); : } > Sorry, forgot to update the commit message. As we talked offline, I think it's the right thing to do to check if the server name specified in the grant/revoke statement is a valid one and throw an AnalysisException is this is not the case. -- To view, visit http://gerrit.cloudera.org:8080/2296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6c136d9a171ec062d4ff803682d026422497e8b Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
