Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2738 Hive/Impala inconsistency in GRANT/REVOKE syntax ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/2296/3/fe/src/main/java/com/cloudera/impala/analysis/PrivilegeSpec.java File fe/src/main/java/com/cloudera/impala/analysis/PrivilegeSpec.java: Line 173: if (serverName_ == null) { Also check if the specified server name is same as the one in the authz configuration. http://gerrit.cloudera.org:8080/#/c/2296/3/fe/src/test/java/com/cloudera/impala/analysis/AnalyzeAuthStmtsTest.java File fe/src/test/java/com/cloudera/impala/analysis/AnalyzeAuthStmtsTest.java: Line 133: // To be consistent with Hive, we allow any server name to be specified. Remove comment. http://gerrit.cloudera.org:8080/#/c/2296/3/testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test File testdata/workloads/functional-query/queries/QueryTest/grant_revoke.test: Line 78: grant all on server server2 to grant_revoke_test_ALL_SERVER This test simply grants the privilege and checks if it has been registered. We also need a test (or maybe modify an existing one to use 'server1') that shows that privileges are actually enforced even if granted/revoked with an explicit name. -- To view, visit http://gerrit.cloudera.org:8080/2296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6c136d9a171ec062d4ff803682d026422497e8b Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-HasComments: Yes
