Marcell Szabo has posted comments on this change.

Change subject: IMPALA-2518: DROP DATABASE CASCADE does not remove cache 
directives of tables
......................................................................


Patch Set 1:

(1 comment)

done

http://gerrit.cloudera.org:8080/#/c/1966/1/tests/query_test/test_hdfs_caching.py
File tests/query_test/test_hdfs_caching.py:

Line 127:   def load_and_drop(self, vector, *drop_statements):
> How about let the load function return the num_entries_pre
separated the two test cases, the generalisation just caused more confusion 
then benefit


-- 
To view, visit http://gerrit.cloudera.org:8080/1966
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58270e1be49e71a08e12021e7dddab01969d1810
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Marcell Szabo <[email protected]>
Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]>
Gerrit-Reviewer: Juan Yu <[email protected]>
Gerrit-Reviewer: Marcell Szabo <[email protected]>
Gerrit-HasComments: Yes

Reply via email to