Marcell Szabo has posted comments on this change. Change subject: IMPALA-2518: DROP DATABASE CASCADE does not remove cache directives of tables ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/1966/3/fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java File fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java: Line 1165: uncacheTableBeforeTruncate > let's rename to uncacheTable(); truncate has a different meaning. Done Line 1166: if (table instanceof HdfsTable) { > if (!(table instanceof HdfsTable)) return; Done Line 1175: if (table.getNumClusteringCols() > 0) { > revert the condition and return to save an indentation level returns in the beginning are ok, but I wouldn't put a return in the middle of a method. http://gerrit.cloudera.org:8080/#/c/1966/3/tests/query_test/test_hdfs_caching.py File tests/query_test/test_hdfs_caching.py: Line 137: self.run_test_case('QueryTest/hdfs-caching', vector) > Please don't run the QueryTest/hdfs-caching again. Can't you just add 1-2 c created QueryTest/hdfs-caching-minimal.test for this purpose. -- To view, visit http://gerrit.cloudera.org:8080/1966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58270e1be49e71a08e12021e7dddab01969d1810 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Marcell Szabo <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Marcell Szabo <[email protected]> Gerrit-HasComments: Yes
