Jim Apple has posted comments on this change. Change subject: IMPALA-2518: DROP DATABASE CASCADE does not remove cache directives of tables ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/1966/3/fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java File fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java: Line 1162: it expects > Very good comment. It would be nice to review the whole metadata solution a If I understand correctly, each step is atomic: 1. drop table 2. uncache table 3. (a) uncache partition foo (b) uncache partition bar ... If someone pulls the power cord after #1, how does a user uncache a table? Would it make sense to move #1 to the end? -- To view, visit http://gerrit.cloudera.org:8080/1966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58270e1be49e71a08e12021e7dddab01969d1810 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Marcell Szabo <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Marcell Szabo <[email protected]> Gerrit-HasComments: Yes
