Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2518: DROP DATABASE CASCADE does not remove cache directives of tables ......................................................................
Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/1966/3/fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java File fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java: Line 1161: error "errors" Line 1162: Does not update partition metadata because It doesn't update both table and partition metadata because the table has already been removed. Can you update this comment? Line 1162: it expects > If I understand correctly, each step is atomic: For the scenario that Jim describes, the user can uncache a table directly through hdfs cacheadmin. Let's not change the order of these operations in this patch because that order is consistently used in other DDL ops as well (e.g. dropPartition). Line 1165: uncacheTableBeforeTruncate let's rename to uncacheTable(); truncate has a different meaning. Line 1166: if (table instanceof HdfsTable) { if (!(table instanceof HdfsTable)) return; Line 1175: if (table.getNumClusteringCols() > 0) { revert the condition and return to save an indentation level http://gerrit.cloudera.org:8080/#/c/1966/3/tests/query_test/test_hdfs_caching.py File tests/query_test/test_hdfs_caching.py: Line 137: self.run_test_case('QueryTest/hdfs-caching', vector) Please don't run the QueryTest/hdfs-caching again. Can't you just add 1-2 cached tables in hdfs-caching and then call drop with cascade at the end of function test_caching_ddl? -- To view, visit http://gerrit.cloudera.org:8080/1966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58270e1be49e71a08e12021e7dddab01969d1810 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Marcell Szabo <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Marcell Szabo <[email protected]> Gerrit-HasComments: Yes
