Alex Behm has posted comments on this change. Change subject: IMPALA-3139: Fix drop table statement to not drop views and vice versa ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/2458/1/fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java File fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java: Line 1133: String errorMsg = (params.is_table ? "Table " : "View ") + tableName + This err msg seems to apply when existingTbl is null. I think we should have a consistent err msg for table/view mismatches like the one in DropTableOrViewStmt Line 1135: if (!params.if_exists) { single line if if fits. http://gerrit.cloudera.org:8080/#/c/2458/1/testdata/workloads/functional-query/queries/QueryTest/views-ddl.test File testdata/workloads/functional-query/queries/QueryTest/views-ddl.test: Line 174: # Test 'if exists' does not drop a table with same name Also test that DROP VIEW does not drop a table case. Line 193: drop table ddl_test_db.drop_view_test not needed, remove may need to fix following expected "SHOW" -- To view, visit http://gerrit.cloudera.org:8080/2458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d35cd1f50d9b8d50223660f753c56529cbbc311 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-HasComments: Yes
