Alex Behm has posted comments on this change. Change subject: IMPALA-3139: Fix drop table statement to not drop views and vice versa ......................................................................
Patch Set 2: (3 comments) I think we should be mindful about compatibility until we are 100% certain we can move away from maintaining it. http://gerrit.cloudera.org:8080/#/c/2458/2/common/thrift/JniCatalog.thrift File common/thrift/JniCatalog.thrift: Line 514: 4: required bool is_table let's make this field optional http://gerrit.cloudera.org:8080/#/c/2458/2/fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java File fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java: Line 1150: Table existingTbl = catalog_.getTable(params.getTable_name().db_name, let's only do this if params.is_table is set for compatibility http://gerrit.cloudera.org:8080/#/c/2458/2/testdata/workloads/functional-query/queries/QueryTest/views-ddl.test File testdata/workloads/functional-query/queries/QueryTest/views-ddl.test: Line 175: create table ddl_test_db.drop_view_test(a int) call the test table something like "test_table" so that it's easy to see that it is a table (and not a view) -- To view, visit http://gerrit.cloudera.org:8080/2458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d35cd1f50d9b8d50223660f753c56529cbbc311 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-HasComments: Yes
