Alex Behm has posted comments on this change. Change subject: IMPALA-3139: Fix drop table statement to not drop views and vice versa ......................................................................
Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/2458/3/fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java File fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java: Line 1156: if (params.isSetIs_table() && ((params.is_table && existingTbl instanceof View) Mention that the isSet check is for maintaining compatibility, and that it means we may incorrectly drop a view with a drop table stmt, -- To view, visit http://gerrit.cloudera.org:8080/2458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d35cd1f50d9b8d50223660f753c56529cbbc311 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-HasComments: Yes
