Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3139: Fix drop table statement to not drop views and vice versa ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/2458/1/fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java File fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java: Line 1133: String errorMsg = (params.is_table ? "Table " : "View ") + tableName + > This err msg seems to apply when existingTbl is null. Done Line 1135: if (!params.if_exists) { > single line if if fits. Moved the errorString into the branch. So not required. http://gerrit.cloudera.org:8080/#/c/2458/1/testdata/workloads/functional-query/queries/QueryTest/views-ddl.test File testdata/workloads/functional-query/queries/QueryTest/views-ddl.test: Line 174: # Test 'if exists' does not drop a table with same name > Also test that DROP VIEW does not drop a table case. Done Line 193: drop table ddl_test_db.drop_view_test > not needed, remove Was lazy to do that, so added a drop here :D. Updated it now :=) -- To view, visit http://gerrit.cloudera.org:8080/2458 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0d35cd1f50d9b8d50223660f753c56529cbbc311 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-HasComments: Yes
