Dan Hecht has posted comments on this change. Change subject: IMPALA-2399: Check for mem limit in allocations in parquet scanner and decompressor ......................................................................
Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/2203/12/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 1569: RETURN_IF_ERROR(state_->CheckQueryState()); > Replaced with GetQueryStatus(). If we are to introduce GetUDFStatus(), we p Sure, that sounds good. My main concern was leaving the calls to AnyLimitExceeded() since that would mask cases this patch didn't fix up but was expecting to. http://gerrit.cloudera.org:8080/#/c/2203/12/be/src/exec/hdfs-scanner.cc File be/src/exec/hdfs-scanner.cc: Line 196: // TODO: move this to ProcessSplit() / ProcessRange(). > If we have to keep it together with FreeLocalAllocations(), it may not be a Let's talk about this. I do think it'd be nice to get rid of parse_status_ eventually, but I think it's there for performance reasons. But maybe we've made enough progress on Status perf that we can remove it. -- To view, visit http://gerrit.cloudera.org:8080/2203 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic70400407b7662999332448f4d1bce2cc344ca89 Gerrit-PatchSet: 12 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Skye Wanderman-Milne <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
