Juan Yu has posted comments on this change. Change subject: IMPALA-1850 allow fs.defaultFS to be set to a non-HDFS filesystem ......................................................................
Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/1121/7/fe/src/main/java/com/cloudera/impala/service/JniFrontend.java File fe/src/main/java/com/cloudera/impala/service/JniFrontend.java: Line 689: fs.getClass().getSimpleName() + ". " + L689 ~ L692, should be 4 space intentation http://gerrit.cloudera.org:8080/#/c/1121/7/tests/query_test/test_delimited_text.py File tests/query_test/test_delimited_text.py: Line 11: @SkipIfS3.insert Move this to specific test. so In the future if we add new tests, we won't skip it accidently. http://gerrit.cloudera.org:8080/#/c/1121/7/tests/query_test/test_partitioning.py File tests/query_test/test_partitioning.py: Line 26: @SkipIfS3.insert Move this to specific test. so In the future if we add new tests, we won't skip it accidently. http://gerrit.cloudera.org:8080/#/c/1121/7/tests/query_test/test_queries.py File tests/query_test/test_queries.py: Line 39: @SkipIfS3.insert why skip this one? it only contains select query. Line 54: @SkipIfS3.insert same here, I don't see any insert query in this test. -- To view, visit http://gerrit.cloudera.org:8080/1121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f45bef6c94ece634045acb906d12591587ccfed Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Anuj Phadke <[email protected]> Gerrit-Reviewer: Anuj Phadke <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
