Sailesh Mukil has posted comments on this change. Change subject: IMPALA-1850 allow fs.defaultFS to be set to a non-HDFS filesystem ......................................................................
Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/1121/9/bin/impala-config.sh File bin/impala-config.sh: Line 103: export FILESYSTEM_PREFIX="s3a://${S3_BUCKET}" > Right, it should be either / or, and this script should enforce that. Ah right, I missed that. http://gerrit.cloudera.org:8080/#/c/1121/9/tests/query_test/test_multiple_filesystems.py File tests/query_test/test_multiple_filesystems.py: Line 11: @SkipIfS3.insert > Why is this being skipped for the reason "insert"? We will lose a lot of co You can ignore this comment too. We need to figure out a different way to run this test. It would be easier to figure that out in person if you want to talk. And I think SkipIfS3.insert and SkipIf.default_fs are still not the way to go. -- To view, visit http://gerrit.cloudera.org:8080/1121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f45bef6c94ece634045acb906d12591587ccfed Gerrit-PatchSet: 9 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Anuj Phadke <[email protected]> Gerrit-Reviewer: Anuj Phadke <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
