Henry Robinson has posted comments on this change. Change subject: IMPALA-1850 allow fs.defaultFS to be set to a non-HDFS filesystem ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/1121/6/bin/impala-config.sh File bin/impala-config.sh: Line 103: export FILESYSTEM_PREFIX="s3a://${S3_BUCKET}" Don't you need to remove this as well? Otherwise two problems: 1. Any tests with SkipIf.not_default_fs will not be run (because default_fs is a function of whether FILESYSTEM_PREFIX is set) 2. All directories are qualified with FILESYSTEM_PREFIX/, so it's not clear that the 'default' nature of S3 is properly being tested because there's no implicit path conversion. Of course, if you remove this then maybe we don't exercise any non-default FS path for any filesystem. If this is important we should add the ability to optionally configure these FSs as the non-default (always with HDFS as the default), which basically boils down to choosing whether to set DEFAULT_FS or FILESYSTEM_PREFIX. -- To view, visit http://gerrit.cloudera.org:8080/1121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f45bef6c94ece634045acb906d12591587ccfed Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Anuj Phadke <[email protected]> Gerrit-Reviewer: Anuj Phadke <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
