Sailesh Mukil has posted comments on this change. Change subject: IMPALA-1850 allow fs.defaultFS to be set to a non-HDFS filesystem ......................................................................
Patch Set 9: (3 comments) Feel free to reach out if you have any questions on the suggested changes. http://gerrit.cloudera.org:8080/#/c/1121/9/bin/impala-config.sh File bin/impala-config.sh: Line 103: export FILESYSTEM_PREFIX="s3a://${S3_BUCKET}" To address Henry's comment (on this line in patch set 6), you can do the following in tests/util/filesystem_util.py: IS_DEFAULT_FS = not FILESYSTEM_PREFIX or IS_LOCAL or (FILESYSTEM_PREFIX and IS_S3) http://gerrit.cloudera.org:8080/#/c/1121/9/fe/src/main/java/com/cloudera/impala/service/JniFrontend.java File fe/src/main/java/com/cloudera/impala/service/JniFrontend.java: Line 688: file system nit: one word http://gerrit.cloudera.org:8080/#/c/1121/9/tests/query_test/test_multiple_filesystems.py File tests/query_test/test_multiple_filesystems.py: Line 11: @SkipIfS3.insert Why is this being skipped for the reason "insert"? We will lose a lot of coverage here and elsewhere. I think you need a better way to address this and all the other tests that are being skipped as a part of this patch. I would suggest adding a new SkipIfS3 parameter where you would only skip when S3 is the default filesystem. (like SkipIfS3.s3_is_default or something of the sort). You can add a new variable in filesystem_util.py to switch this new SkipIfS3 on and off: IS_DEFAULT_S3 = IS_S3 and IS_DEFAULT_FS And use this new SkipIfS3 reason everywhere in this patch as applicable. -- To view, visit http://gerrit.cloudera.org:8080/1121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f45bef6c94ece634045acb906d12591587ccfed Gerrit-PatchSet: 9 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Anuj Phadke <[email protected]> Gerrit-Reviewer: Anuj Phadke <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Juan Yu <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
